Skip to content

Commit

Permalink
🎨 Address @frosforever's code review
Browse files Browse the repository at this point in the history
 - Use defined constant instead of magic string
  • Loading branch information
AlainODea committed Aug 21, 2018
1 parent 87f90ac commit c3170bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/okta/tools/aws/settings/Credentials.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public Credentials(Reader reader, OktaAwsCliEnvironment environment) throws IOEx
* @param awsSessionToken The session token to use for the profile.
*/
public void addOrUpdateProfile(String name, String awsAccessKey, String awsSecretKey, String awsSessionToken) {
name = "default".equals(name) ? "default" : name + environment.credentialsSuffix;
name = DEFAULT_PROFILE_NAME.equals(name) ? DEFAULT_PROFILE_NAME : name + environment.credentialsSuffix;
setProperty(name, ACCES_KEY_ID, awsAccessKey);
setProperty(name, SECRET_ACCESS_KEY, awsSecretKey);
setProperty(name, SESSION_TOKEN, awsSessionToken);
Expand Down

0 comments on commit c3170bb

Please sign in to comment.