-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N-Gram Example Comment Incorrect? #53
Comments
... and I just noticed after posting this that 0.583333 ~= (1 - 0.416666). So this is an issue of difference vs similarity I guess. But I suppose we still need to confirm if the returned value from the library is incorrect, or if the comment is incorrect. |
I think this might be a case of the README being incorrect, as it looks like the logic was changed as a result of #22 |
tdebatty
added a commit
that referenced
this issue
Oct 7, 2019
Fix issue #53 Many thanks to @paulirwin for the thorough issue analysis!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was reported to my team's .NET port of your library but I confirmed that it is an issue here as well.
The example on the README shows that the N-Gram code expects values of 0.416666 and 0.97222. However, different results are given when the code is actually ran. I am not sure if this is a bug in the code, or that the README comment is outdated/incorrect.
I created a unit test for the README example, and sure enough it fails:
Results:
This result (0.583) is the same that we get on the .NET side of things. As I am not an expert in these algorithms, I am unsure if this is a code bug or a need to update the README.
The text was updated successfully, but these errors were encountered: