Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'function' built-in. #77

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
faab6cc
Introduce 'function' built-in
Krush206 Jul 7, 2023
b683769
sh.c: Sgoal shouldn't be assigned funcmain
Krush206 Jul 7, 2023
4d90ff3
sh.c: cleanup_push() raises SIGSEGV
Krush206 Jul 8, 2023
715a882
fargv should be freed from dofunction()
Krush206 Jul 8, 2023
5e37bfc
Move function tests to srcunit()
Krush206 Aug 5, 2023
235b358
Better function parsing
Krush206 Nov 21, 2023
4a54e05
Create tests for 'function' built-in
Krush206 Nov 21, 2023
5bc9252
sh.c: call cleanup_push() properly
Krush206 Nov 21, 2023
b1e4135
Documentation for 'function' built-in
Krush206 Nov 21, 2023
ede350d
Rename ERR_DOLFUNC to ERR_FUNC
Krush206 Nov 21, 2023
fc7dbd3
sh.func.c: prefer dolzero over ffile
Krush206 Nov 21, 2023
d762fba
sh.func.c: allocate memory properly
Krush206 Nov 21, 2023
951264d
sh.func.c: assign NULL after deallocating fargv
Krush206 Nov 22, 2023
7d6eef8
Prefer srcfile() over dosource()
Krush206 Dec 3, 2023
c60a4c2
Functions should work for sourced scripts.
Krush206 Feb 14, 2024
954cfd6
Rethought on functions
Krush206 May 18, 2024
15d4e30
Do not fork & fix interrupts
Krush206 Jun 2, 2024
042e84b
Refactor
Krush206 Jun 3, 2024
2fa7967
tcsh.man.in: correction & additional information
Krush206 Jun 3, 2024
b950b85
sh.err.c: recursion/nest
Krush206 Jun 3, 2024
d840e89
Create aliases for functions
Krush206 Jun 3, 2024
22d3150
sh.func.c: replace setexit with cleanup_push
Krush206 Jun 4, 2024
adea1b6
Avoid SIGPIPE on doexit
Krush206 Jun 4, 2024
d0167d4
sh.func.c: don't catch OLDSTD
Krush206 Jun 4, 2024
911ed6e
22d3150: move remaining parts to st_restore
Krush206 Jun 6, 2024
56e5e7d
911ed6e: more remaining parts
Krush206 Jun 7, 2024
c8b8f51
Prefer dozip over doreturn
Krush206 Jun 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move function tests to srcunit()
  • Loading branch information
Krush206 committed Jun 1, 2024
commit 5e37bfce72113dce4c1772a57fff1ed2d5c29cd9
108 changes: 54 additions & 54 deletions sh.c
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,60 @@ srcunit(int unit, int onlyown, int hflg, Char **av)
cleanup_push(&pintr_disabled, disabled_cleanup);
}

/* Functions must have an exit to their end.
* if (!fargv->prev) is only true if this is a first function call.
* First seek for an exit before jumping to the label,
* then seek for an exit on the requested label.
* Function arguments are passed to STRargv.
* STRargv is reset after the function is done. */
if (fargv) {
int funcdelim = 0;
Char funcexit[] = { 'e', 'x', 'i', 't', 0 },
funcmain[] = { 'm', 'a', 'i', 'n', 0 };
struct Strbuf aword = Strbuf_INIT;
Sgoal = fargv->v[2];
Stype = TC_GOTO;

if (!fargv->prev)
while (!funcdelim) {
(void) getword(&aword);
Strbuf_terminate(&aword);

if (aword.s[0] != ':' && lastchr(aword.s) == ':')
funcerror(funcmain, funcexit);
else if (eq(aword.s, funcexit))
funcdelim = 1;

(void) getword(NULL);
}

setq(STRargv, &fargv->v[3], &shvhed, VAR_READWRITE);
dogoto(&fargv->v[1], fargv->t);

{
struct Ain a;

Stype = TC_EXIT;
a.type = TCSH_F_SEEK;
btell(&a);
funcdelim = 0;

while (!funcdelim) {
(void) getword(&aword);
Strbuf_terminate(&aword);

if (aword.s[0] != ':' && lastchr(aword.s) == ':')
funcerror(Sgoal, funcexit);
else if (eq(aword.s, funcexit))
funcdelim = 1;

(void) getword(NULL);
}

bseek(&a);
}
}

process(0); /* 0 -> blow away on errors */

/* Restore the old state */
Expand Down Expand Up @@ -1997,60 +2051,6 @@ process(int catch)
getexit(osetexit);
omark = cleanup_push_mark();

/* Functions must have an exit to their end.
* if (!fargv->prev) is only true if this is a first function call.
* First seek for an exit before jumping to the label,
* then seek for an exit on the requested label.
* Function arguments are passed to STRargv.
* STRargv is reset after the function is done. */
if (fargv) {
int funcdelim = 0;
Char funcexit[] = { 'e', 'x', 'i', 't', 0 },
funcmain[] = { 'm', 'a', 'i', 'n', 0 };
struct Strbuf aword = Strbuf_INIT;
Sgoal = fargv->v[2];
Stype = TC_GOTO;

if (!fargv->prev)
while (!funcdelim) {
(void) getword(&aword);
Strbuf_terminate(&aword);

if (aword.s[0] != ':' && lastchr(aword.s) == ':')
funcerror(funcmain, funcexit);
else if (eq(aword.s, funcexit))
funcdelim = 1;

(void) getword(NULL);
}

setq(STRargv, &fargv->v[3], &shvhed, VAR_READWRITE);
dogoto(&fargv->v[1], fargv->t);

{
struct Ain a;

Stype = TC_EXIT;
a.type = TCSH_F_SEEK;
btell(&a);
funcdelim = 0;

while (!funcdelim) {
(void) getword(&aword);
Strbuf_terminate(&aword);

if (aword.s[0] != ':' && lastchr(aword.s) == ':')
funcerror(Sgoal, funcexit);
else if (eq(aword.s, funcexit))
funcdelim = 1;

(void) getword(NULL);
}

bseek(&a);
}
}

for (;;) {
struct command *t;
int hadhist, old_pintr_disabled;
Expand Down