Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder constructor arguments #8

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Reorder constructor arguments #8

merged 2 commits into from
Mar 21, 2022

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Mar 21, 2022

As discussed with @gibson042 elsewhere, the Intl.MessageFormat constructor ought to have its required argument (resource) before the optional ones (locales and options).

@eemeli eemeli requested a review from dminor March 21, 2022 14:31
@dminor
Copy link
Collaborator

dminor commented Mar 21, 2022

lgtm

@dminor dminor merged commit 9149c8a into main Mar 21, 2022
@dminor dminor deleted the optional-after-required branch March 21, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dminor dminor Awaiting requested review from dminor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eemeli @dminor