Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate toolbox items into independently-wrappable "words" #554

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Sep 4, 2023

The current toolbox cannot wrap in between "Permalink" and "Pin" or "Pin" and "References (…)" (and thus can horizontally overflow the viewport when a definition is near the right margin), but can wrap in between "References" and "(…)" (splitting a link and on the second line intruding into what otherwise looks like box padding). This PR disables wrapping inside those links and inserts break opportunities in between them.

Before

screenshot (before change)

After

screenshot (after change)

The excess horizontal width is a known issue with CSS "shrink-wrapping" that already exists and is not changed by this PR:

current excessive width

screenshot of current excessive width

@bakkot bakkot merged commit 65103ee into tc39:main Sep 4, 2023
2 checks passed
@bakkot
Copy link
Contributor

bakkot commented Sep 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants