Normative: Create global properties for sloppy function hosting as vars #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes a case where a synthetic *undefined* was visible as a result of legacy sloppy-mode function hoisting. This patch addresses tc39#753
littledan
added
normative change
|
I wondered why we decided to use CanDeclareGlobalFunction/CreateGlobalFunctionBinding instead of CanDeclareGlobalVar/CreateGlobalVarBinding, and look what I found -> https://bugs.ecmascript.org/show_bug.cgi?id=4428#c1. 😄 I think @syg should take a look at this change to confirm that this matches what he implemented in SpiderMonkey. |
rwaldron
added
needs consensus
|
I'm pretty sure the PR matches my implementation. Sorry I completely forgot to respond to this. |
rwaldron
added
has consensus
|
I think TC39 was happy with this sort of thing ultimately, right? |
|
I believe we got consensus here. Aside from addressing code review feedback on the tests, does anything else need to be fixed up for this patch to land? |
|
Spec tests landed: tc39/test262#969 |
ljharb
added
has test262 tests
and removed
needs test262 tests
ljharb
approved these changes
May 12, 2018
bmeck
approved these changes
Jul 18, 2018
bterlson
approved these changes
Jul 18, 2018
ljharb
force-pushed
the
fix-function-annex-b
branch
from
d485211
to
caf89a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a case where a synthetic undefined was visible
as a result of legacy sloppy-mode function hoisting.
This patch addresses #753