Implement SharedArrayBuffer & Atomics #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a rendering: https://tc39.github.io/ecma262/sab/ |
|
Here's the test262 PR: tc39/test262#839 |
….6 as notes at the end of the memory model section
* Editorial: put Memory Model notes in their own subclause
The emu-clause for "Memory Model" contains some introductory stuff,
followed by a bunch of sub-emu-clauses,
followed by 3 emu-notes.
Now, although these notes are (in the HTML)
children of the Memory Model clause,
I suspect that when rendered,
they'll *look* like they're part of
the last of the sub-clauses ("Data Race Freedom"),
which you probably don't want.
So, to prevent this, I put the three notes in their own sub-clause.
* Editorial: in <li> with block items, put inline items in <p>
It's unusual (at least in this document)
for a <li> to contain both inline items (<em> and text) and block items (<p>).
Embed the inline items in a <p>.
(Also, adjust the linebreaking and indenting accordingly.)
* Editorial: Add </li> tags
* Editorial: insert missing </emu-xref> tag
* Editorial: fix misspelled </emu-xref> tag
* Editorial: insert missing close-backticks
* Editorial: put missing underscores around metavariables
* Editorial: put missing asterisks around "true"
* Editorial: put missing backticks around string literal
* Editorial: insert missing "that"
* Editorial: change "the List" to "a List" in a few places
* Editorial: various wording tweaks re empty List
"the empty list" -> "a new empty List" or "an empty List" as appropriate
"an empty List" -> "a new empty List"
* Editorial: remove asterisks from *0* and *1*
For one thing, 0 (per se) doesn't exist as an ES value.
More generally, spec algorithms can use abstract/mathematical integers
without having to relate them to Number values.
* Editorial: add "Record" to anonymous record constructors
(Should maybe be "Chosen Value Record".)
* Editorial: delete pointless Zero-Width Joiner
* Editorial: remove extra indent on 2 algorithm steps
* Editorial: insert and delete a few spaces
* Editorial: insert comma before "then"
* Editorial: misc tweaks to algorithm wording
... mostly for consistency
* Editorial: change "a event" to "an event"
* Editorial: disambiguate a dangling else
This is a case of "dangling else" (or "dangling otherwise"),
and it's not obvious which "if" the "otherwise" associates with.
I've rewritten it to remove the ambiguity.
Please check whether I got the intent right.
(If not, you might want to rewrite as multiple steps,
so that the logic is clear.)
7ef4f1d
to
d617a6e
Compare
|
This has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the contents from ecmascript_sharedmem in advance of stage 4 approval next week. Minor editorial updates (and minor bug fixes) were made but otherwise no changes.
Test262 updates are pending.