Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up definition of Immutable Prototype Exotic Objects #731

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

littledan
Copy link
Member

- Explicitly state that they are just like ordinary objects, and have
  the same internal slots, except for one weird trick. (closes tc39#705)
- Factor out the body of the [[SetPrototypeOf]] method of immutable
  prototype exotic objects into an abstract operation to make it
  easier to do integration with embedders.
  (see whatwg/html#2035)
</emu-alg>
</emu-clause>

<emu-clause id="sec-set-immutable-prototype">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a source file comment <!-- This is used by host environment specs, even though it only has one consumer in this spec; don't inline it -->

Copy link
Member Author

@littledan littledan Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other things that we organize for layering reasons; are there examples of similar comments that I could follow the trend of?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at this time, I don't think, but it's been mentioned before as a good idea we might want to start doing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using HTML comments for editorial notes to self are a fine idea. In general, I don't thing like this should be part of the rendered spec. text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comment; is this patch good to submit now?

@littledan
Copy link
Member Author

cc @allenwb

@bterlson bterlson merged commit 45e8905 into tc39:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immutable Prototype Exotic Objects is underspecified
4 participants