Normative: Allow FiB to be redeclared in non-strict mode Annex B. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably better to add this commit to #400. Easier to review together. |
| 1. If the production is contained in strict mode code, then | ||
| 1. Append to _names_ the elements of the TopLevelLexicallyDeclaredNames of |StatementListItem|. | ||
| 1. Else, | ||
| 1. If |StatementListItem| is <emu-grammar>StatementListItem : Declaration</emu-grammar> and |Declaration| is <emu-grammar>Declaration : HoistableDeclaration</emu-grammar> and |HoistableDeclaration| is <emu-grammar>HoistableDeclaration : FunctionDeclaration</emu-grammar> , then |
There was a problem hiding this comment.
I think it is possible to use the following abbreviation (just in case you want to shorten the if-condition).
If |StatementListItem| is <emu-grammar>StatementListItem : Declaration</emu-grammar> and DeclarationPart(|Declaration|) is |FunctionDeclaration|, then
syg
force-pushed
the
fib-allow-redecl
branch
from
3d6532f
to
9603ef7
Compare
|
Closing this and folding it into #400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #320. @littledan is co-championing (perhaps also reviewing?) this.
Note that this will most likely need to be rebased on top of #400.