Normative: Specify \8 and \9 in sloppy non-template strings. #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkirsling
commented
Jun 16, 2020
spec.html
Outdated
| @@ -42121,15 +42122,15 @@ <h2>Syntax</h2> | |||
|
|
|||
| FourToSeven :: one of | |||
| `4` `5` `6` `7` | |||
|
|
|||
| NonOctalDecimalEscapeSequence :: one of | |||
There was a problem hiding this comment.
This could just be an alias for NonOctalDigit, but I think SV would be less clean to specify that way? Feel free to correct me though.
rkirsling
changed the title
michaelficarra
approved these changes
Jul 16, 2020
ljharb
added
has test262 tests
needs consensus
syg
approved these changes
Jul 29, 2020
bakkot
approved these changes
Jul 30, 2020
ljharb
force-pushed
the
sloppy-noctal-escapes
branch
from
5ad7b0c
to
7efaa50
Compare
pull bot
pushed a commit
to Alan-love/v8
that referenced
this pull request
Aug 3, 2020
This reached consensus in the July 2020 TC39: tc39/ecma262#2054 Bug: v8:10769 Change-Id: Iecea1d9d9c9be5c2fbfb820aed2285719c4e6382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2333350 Commit-Queue: Shu-yu Guo <[email protected]> Reviewed-by: Marja Hölttä <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#69206}
This was referenced Oct 5, 2020
jmdyck
added a commit
to jmdyck/test262-parser-tests
that referenced
this pull request
Jan 30, 2021
These tests were expected to raise a syntax error because they have a string literal containing \8 or \9, which used to be disallowed. However, they have been allowed (via NonOctalDecimalEscapeSequence) since the merge of tc39/ecma262#2054.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2039.
Specifically:
`\8`and`\9`so no action is needed there.'\8'and'\9'are just'8'and'9'in sloppy mode, so specify that in B.1.2.'\8'and'\9'in strict mode, so there should be no web compatibility risk.Tests: tc39/test262#2654