add Symbol.prototype.description getter #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
added
the
pending stage 4
ljharb
added
normative change
ljharb
approved these changes
Nov 14, 2018
zenparsing
approved these changes
Nov 14, 2018
| <p>`Symbol.prototype.description` is an accessor property whose set accessor function is *undefined*. Its get accessor function performs the following steps:</p> | ||
| <emu-alg> | ||
| 1. Let _s_ be the *this* value. | ||
| 1. Let _sym_ be ? thisSymbolValue(_s_). |
There was a problem hiding this comment.
You could also do
Let _sym_ be ? thisSymbolValue(*this* value).
There was a problem hiding this comment.
The reigning convention seems to be to have it in a separate variable; i don’t have a strong opinion either way as long as we’re consistent.
19 tasks
michaelficarra
removed
the
pending stage 4
|
@tc39/ecma262-editors I've removed the |
ljharb
added
es2019
has stage 4
bterlson
approved these changes
Feb 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the stage 3 symbol description proposal in preparation for stage 4.
As of this writing, there are three compatible browser implementations.