[Normative] Make Array.prototype.sort stable #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
added
editorial change
needs consensus
|
Added to November agenda: tc39/agendas@4fdf671 |
ljharb
added
normative change
|
This got consensus at today’s TC39 meeting. 🎉 |
ljharb
added
has consensus
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Nov 29, 2018
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Nov 29, 2018
|
Test262 tests: tc39/test262#1977 |
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Nov 30, 2018
littledan
added
has test262 tests
and removed
needs test262 tests
|
Since this has tests and consensus, is it ready to merge? |
|
The tests aren’t merged yet. |
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Dec 6, 2018
|
@ljharb They are now! |
ljharb
approved these changes
Dec 6, 2018
zenparsing
approved these changes
Dec 6, 2018
mathiasbynens
force-pushed
the
sort-stability
branch
from
cca5a66
to
a85c9d9
Compare
|
I know it's not my place, but lgtm! |
mathiasbynens
force-pushed
the
sort-stability
branch
from
a85c9d9
to
2624806
Compare
ljharb
approved these changes
Dec 10, 2018
|
FWIW, Mozilla would be ok with making sort stability normative for TypedArray#sort as well, even before our implementation is compliant. |
bterlson
approved these changes
Jan 29, 2019
|
V8 would be too. As soon as this PR is merged, I’ll work on a follow-up PR that makes |
All major JavaScript engines now have a stable Array.prototype.sort implementation. Let’s update the spec accordingly. References: - https://v8.dev/blog/array-sort - chakra-core/ChakraCore@c565b12 - https://mathiasbynens.be/demo/sort-stability - https://docs.google.com/presentation/d/1mHvxDciqsAchhjepMZlU5fn1DBvglCXSjDWUEtsPGvI/edit
ljharb
force-pushed
the
sort-stability
branch
from
2624806
to
257cae9
Compare
mathiasbynens
added a commit
to mathiasbynens/ecma262
that referenced
this pull request
Jan 29, 2019
Currently, only V8 [1] and SpiderMonkey [2] have unstable `%TypedArray%.prototype.sort` implementations. Both teams have publicly committed to making their implementations stable, to match `Array.prototype.sort` [3]. [1] https://bugs.chromium.org/p/v8/issues/detail?id=8567 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1290554 [3] tc39#1340 (comment)
OP delivers: #1433 |
lapo-luchini
added a commit
to lapo-luchini/pinry
that referenced
this pull request
Dec 4, 2019
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All major JavaScript engines now have a stable
Array.prototype.sortimplementation. Let’s update the spec accordingly.References: