chore(deps): Upgrade to ndk 0.9 and delete unused ndk-sys/context dependencies
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ndk` crate received some marginal API upgrades, besides fixing soundness issues. Specifcally, `ForeignLooper::add_fd_with_callback()` now signifies that the incoming file descriptor is a `BorrowedFd` and the callback is executed on a different thread (where the looper is polled on the `ThreadLooper`) and must hence be `Send.`. It appears the `ndk-sys` and `ndk-context` crates are not used directly, hence they are removed from `Cargo.toml` here.
MarijnS95
commented
Jun 17, 2024
| let mut pipe: [RawFd; 2] = Default::default(); | ||
| unsafe { libc::pipe(pipe.as_mut_ptr()) }; | ||
| pipe | ||
| unsafe { pipe.map(|fd| OwnedFd::from_raw_fd(fd)) } |
There was a problem hiding this comment.
It might be more convenient to use rustix here.
| let size = std::mem::size_of::<bool>(); | ||
| let mut wake = false; | ||
| if libc::read(MAIN_PIPE[0], &mut wake as *mut _ as *mut _, size) == size as libc::ssize_t { | ||
| if libc::read(fd.as_raw_fd(), &mut wake as *mut _ as *mut _, size) == size as libc::ssize_t { | ||
| main_pipe.recv().is_ok() |
There was a problem hiding this comment.
Note that the compiler points out that main_pipe is not Send, so this won't compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1060, #1061
The
ndkcrate received some marginal API upgrades, besides fixing soundness issues. Specifcally,ForeignLooper::add_fd_with_callback()now signifies that the incoming file descriptor is aBorrowedFdand the callback is executed on a different thread (where the looper is polled on theThreadLooper) and must hence beSend..It appears the
ndk-sysandndk-contextcrates are not used directly, hence they are removed fromCargo.tomlhere.