Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix data url html encoding issue #8762

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

huangmingg
Copy link

@huangmingg huangmingg commented Feb 4, 2024

closes #8760

Goal here

  • Introduce DataUrl as a new WebViewUrl variant. This is because while data url strings work with existing variants, it does not really belong to any of it.
  • Change url field of PendingWebview from String to Url, as the method to build a webview differ depending on the kind of URL.
  • Pass the html string in a raw format to WRY, and let WRY handle the encoding instead.

WIP

  • Right now it requires users to pass in encoded strings to properly work. Perform that operation in tauri directly
  • Able to clean up the html helper functions, and perhaps separate html from url, similar to what WRY is doing

Tested on windows:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] HTML encoding issue for data-url
1 participant