Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libraries flag to MacConfig (1.x) #8497

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

dongcarl
Copy link

For macOS apps leveraging SMAppService, we need to place a codesigned plist under the app's Contents/Library/LaunchDaemons directory. This is outside of the Contents/Resources directory so we can't use the resources flag.

The PR as it stands adds a libraries flag to MacConfig to allow this

@dongcarl dongcarl requested a review from a team as a code owner December 29, 2023 20:44
@dongcarl dongcarl force-pushed the 2023-12-macOS-Library-resources branch from ff9075c to d849974 Compare December 29, 2023 20:45
@dongcarl dongcarl changed the title feat: add libraries flag to MacConfig feat: 1.x: add libraries flag to MacConfig Dec 29, 2023
@dongcarl dongcarl changed the title feat: 1.x: add libraries flag to MacConfig feat: add libraries flag to MacConfig (1.x) Dec 29, 2023
@FabianLars
Copy link
Member

Thanks for contributing! We recently merged a similar PR into dev (v2) here #7798 and i think it'd make more sense to backport this / match its name and behavior :)
( -> i'm not sure that a simple git cherry pick would be easy so i would be fine if it's recreated instead 🤷 )

Also, we require all commits to be signed to merge a PR. Here's a guide for that: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification - i recommend the ssh approach because i think it's easier but a guide for gpg is right above that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants