[feat] On Windows, set name of Window Class, closes #7498 #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow to customize it instead of current value hard coded "Window Class"
allow to customize the window class name instead of current value hard coded "Window Class"
* feat: add window_classname, closes tauri-apps#7498
* add changes file
* Update core/tauri-config-schema/schema.json
* Update tooling/cli/schema.json
amrbashir
requested changes
Aug 30, 2023
Comment on lines
+3
to
+4
| "tauri-runtime-wry": 'minor:feat' | ||
| "tauri-runtime": 'minor:feat' |
There was a problem hiding this comment.
Let's remove these two and split the other two bumps into two change files.
Comment on lines
+973
to
+982
| #[cfg(windows)] | ||
| fn window_classname<S: Into<String>>(mut self, window_classname: S) -> Self { | ||
| self.inner = self.inner.with_window_classname(window_classname); | ||
| self | ||
| } | ||
|
|
||
| #[cfg(not(windows))] | ||
| fn window_classname<S: Into<String>>(self, _window_classname: S) -> Self { | ||
| self | ||
| } |
There was a problem hiding this comment.
Suggested change
| #[cfg(windows)] | |
| fn window_classname<S: Into<String>>(mut self, window_classname: S) -> Self { | |
| self.inner = self.inner.with_window_classname(window_classname); | |
| self | |
| } | |
| #[cfg(not(windows))] | |
| fn window_classname<S: Into<String>>(self, _window_classname: S) -> Self { | |
| self | |
| } | |
| fn window_classname<S: Into<String>>(mut self, _window_classname: S) -> Self { | |
| #[cfg(windows)] | |
| { | |
| self.inner = self.inner.with_window_classname(_window_classname); | |
| } | |
| self | |
| } |
| /// | ||
| /// ## Platform-specific | ||
| /// | ||
| /// - **Linux / iOS / Android:** Unsupported. |
There was a problem hiding this comment.
Suggested change
| /// - **Linux / iOS / Android:** Unsupported. | |
| /// - **macOS / Linux / iOS / Android:** Unsupported. |
Comment on lines
+975
to
+976
| #[serde(default = "default_window_classname")] | ||
| pub window_classname: String, |
There was a problem hiding this comment.
Instead of providing a default, lets change this to an Option<String>
Comment on lines
+70
to
+72
| [patch.crates-io] | ||
| tao = {git = "https://github.com/geraudloup/tao"} | ||
|
|
There was a problem hiding this comment.
remove and use the latest tao version
| /// | ||
| /// ## Platform-specific | ||
| /// | ||
| /// - **Linux / iOS / Android:** Unsupported. |
There was a problem hiding this comment.
Suggested change
| /// - **Linux / iOS / Android:** Unsupported. | |
| /// - **macOS / Linux / iOS / Android:** Unsupported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to customize it instead of current value hard coded "Window Class" for all Tauri windows...
From #7498 : Currently, on Windows, all app windows created by tauri have the same class named "Window Class", it would be neet to allow for customization of the Windows' window class name.
One use case: some windows custom hotkey managers leverage window class names to select windows...
Non breaking, since the default value passed corresponds to the previous value that was hard-coded.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This feature depends on an evolution of Tao, which has been already merged today by @amrbashir : tauri-apps/tao#770