feat(core): allow extending the shell scope, closes #5910 #7165
Conversation
| pub command: std::path::PathBuf, | ||
| command: PathBuf, | ||
|
|
||
| /// The arguments the command is allowed to be called with. | ||
| pub args: Option<Vec<ScopeAllowedArg>>, | ||
| args: Option<Vec<ScopeAllowedArg>>, | ||
|
|
||
| /// If this command is a sidecar command. | ||
| pub sidecar: bool, |
There was a problem hiding this comment.
this is a breaking change, any reason to hide these?
There was a problem hiding this comment.
This struct was only used on codegen, no public API returned or takes it as input. I've hidden this so no one use it instead of the builder, which is the stable API.
There was a problem hiding this comment.
It still shows in documentation https://docs.rs/tauri/latest/tauri/scope/struct.ShellScopeAllowedCommand.html so even if no functions take it as input, we can't break it
There was a problem hiding this comment.
And if it is not meant to be used by users anyway, it won't hurt to keep the fields public anyways and maybe add a TODO to hide the type from docs and make the fields private
|
I assume this won't be merged into v1 anymore, right? Should we close it then and queue it for v2 migration? |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information