feat: allow setting window size and position using physical units close #5228

[ysinsane]

Close #5228

What kind of change does this PR introduce?

• Bugfix
• Feature
• Docs
• New Binding issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes, and the changes were approved in issue #___
• No

Checklist

• When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
• A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
• I have added a convincing reason for adding this feature, if necessary

Other information

[ysinsane]

@amrbashir May I ask anything more I could do on this PR? I am willing to do more to pass this PR.

[amrbashir]

It is just waiting for lucas review. He is a bit busy so we appreciate your patience.

[lucasfernog]

I did check it a week ago and I think we should consider a different format for specifying physical units. My first idea was to use a number for logical values e.g. 100 and a string for physical ones such as 100px. The approach on this PR is kinda restrictive since you can't mix logical and physical values in the configuration.

[amrbashir]

I think @ysinsane had that before, where we add a sizeUnit and positionUnit fields but I asked him to combine them but I am fine with changing them back.

I think 100px would hint at there maybe some other css units like 100vw and I don't like that.

[ysinsane]

I actually kind of like lucas's idea, although it takes more work to implement it. As for detail, I'd like to know your idea on mix of logical and physical unit, for example 100 window width and 100px window height?
Cause I found it is not supported by the WRY API. @lucasfernog

[amrbashir]

I don't feel like we should support different width and height. It doesn't make sense tbh and since it requires changes upstream I don't think we should do it now, maybe after switch to winit. For now, we can just add sizeUnit and positionUnit, what do you think @lucasfernog ?

[lucasfernog]

Yeah we shouldn't mix different formats for the same property. I think for v1 we could go with the unit parameters, but refactor the entire configuration format for v2.

[Miniontoby]

Hi!

I am now using this branch/fork and I don't seem to get it to work yet; as in the sizes still don't work...

When I manually correct it with shortcuts from windows it looks like:

So yeah the code I use:

const webviewwindow = new WebviewWindow('presentation', {
    url: this.url, fullscreen: true, resizable: false,
    title: 'presentation',
    x: monitor.position.x, y: monitor.position.y,
    width: monitor.size.width, height: monitor.size.height,
    pixelUnit: 'physical'
});

What am I doing wrong?

Btw when adding this code:

webviewwindow.once('tauri:https://created', async function () {
    console.log(monitor.position, await webviewwindow.innerPosition())
    console.log(monitor.size, await webviewwindow.innerSize())
});

This is the output:

{ "type": "Physical", "x": -1680, "y": -908 }, { "type": "Physical", "x": -1680, "y": -908 }

{ "type": "Physical", "width": 1680, "height": 1050 }, { "type": "Physical", "width": 1920, "height": 1080 }