Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Window builder physical size/position #5228

Open
WilliamVenner opened this issue Sep 18, 2022 · 6 comments · May be fixed by #5381
Open

[feat] Window builder physical size/position #5228

WilliamVenner opened this issue Sep 18, 2022 · 6 comments · May be fixed by #5381
Labels
good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it type: feature request

Comments

@WilliamVenner
Copy link
Contributor

Describe the problem

There's no way to set the size and position of the window in the window builder to physical coordinates.

Describe the solution you'd like

The size and position methods should be able to accept either logical or physical units.

Alternatives considered

Setting the window size and position AFTER the window has been created, which for some reason accepts logical or physical coordinates despite the fact that the window builder doesn't? 🤔

Additional context

My use case is positioning a window on a specific monitor. This can only be done with physical units :(

@amrbashir amrbashir added good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it labels Sep 19, 2022
@ysinsane
Copy link

ysinsane commented Oct 2, 2022

Hi, I am working on this issue. I plan to add some config fields about size and position.

  1. physical_width: Option
  2. physical_height: Option
  3. physical_x: Option
  4. physical_y: Option
    And I will use these values to overide those corresponding config without physical if any of those values is not None.

@ysinsane
Copy link

Hi, may I ask if you need the set position pixel unit and size unit seperately or you just want a total switch?

@WilliamVenner
Copy link
Contributor Author

@amrbashir
Copy link
Member

for now just add inner_size_physical, min_inner_size_physical...and so on, and we can change it in v2 to take either LogicalSize or PhysicalSize

@tankh99
Copy link

tankh99 commented Jul 6, 2024

Hi there, I'd like to help out with this issue. Is this issue being worked on by someone else?

@FabianLars
Copy link
Member

Not that we know off, but after the conversation here and in #5381 i'm not sure what the wanted approach is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it type: feature request
Projects
Status: 📬Proposal
Development

Successfully merging a pull request may close this issue.

5 participants