Olives: Escape todo title in list rendering (#397) #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
added a commit
that referenced
this pull request
Jan 28, 2013
Olives: Escape todo title in list rendering (#397)
|
Works for me. Thanks ;) |
|
Great, one more item to tick off the list. :) |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
Olives: Escape todo title in list rendering (tastejs#397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the HTML escaping in the titles for the Olives example. See #397.
I opted for textContent, which obviously doesn't work in < IE 9. Olives seems to rely on some features like element.classList though which are only available in IE 10, so that shouldn't matter.