New examples guidelines #1910
New examples guidelines #1910
Conversation
contributing.md
Outdated
| - [x] The framework/stack you are using is at least 1 year old. | ||
| - [x] The framework you are using should have at least 5k stars if it is hosted on Github or equivalent on other platforms. | ||
| - [x] Your app should be able to work on recent versions of all major browsers. | ||
| - [x] Your app should bring something truly new to the table, but minor variations of existing frameworks , languages or existing TodoMVC apps. |
There was a problem hiding this comment.
I believe that's a typo? "but not minor variations..."?
There was a problem hiding this comment.
Will fix it, thanks 👍
|
I think this is good - the requirements need to be fairly strict as otherwise there will be a continual need to evaluate small company or individual frameworks. This just wouldn't be possible. I think it is worth clarifying what is meant by 'brings something truly new to the table'. We could start with a summarised list of the features that the current repositories have. |
|
@WhiteFire0 I do not think an exhaustive list of features is the solution I think the first four guidelines are yes-no questions which is what we need but the last one just means your example has to be different because people can always use the same stack in different ways. I think we will always have to discuss and think if an app is a good addition or not but the first 4 guidelines are going to help us a lot in the decision making process |
|
@ahmed-90 Fixed the typo and rephrased the statement. |
|
@FadySamirSadek Looks good to me. 👍 |
|
@ahmed-90 I think this should be added incrementally. I think we should add lighthouse to our CI system but this can be added in an hour in the future. Will open an issue for it and feel free to submit a PR. |
solves #1886