Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added countdown format displaying the days until due #1742

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JamesL813
Copy link

@JamesL813 JamesL813 commented Jan 20, 2022

ex: "18D", "3H", or "35M" rather than the due date and/or time.

I find this makes it easier to gauge the actual time you have to complete a task

…tdown format displaying the days until due ex: "18D", "3H", or "35M" rather than the date and/or time
@JamesL813
Copy link
Author

JamesL813 commented Jan 20, 2022

Screenshots:

task list with option enabled:
image

widget with option enabled
image

menu toggle:
image

@abaker
Copy link
Member

abaker commented Jan 20, 2022

Thanks for the PR!

I haven't gotten a chance to test it yet, but the first few things that come to mind

  • does this work OK when sorting/grouping by due date?
  • when something is due e.g. in 5m, will it tick down to 4m, 3m, etc? this is an issue with other things in the app, like due dates turning red when they become overdue, and due/created/modified sort groups at midnight
  • the actual strings probably need to be translated, and I'm not sure if it will just be %d%s for H, M, and D, or if there will need to be separate translations for each

@JamesL813
Copy link
Author

Thanks for the reply!

I'll do some more testing tonight and I'll see what I can do about the strings. Hopefully I'll get back with an update!

@JamesL813
Copy link
Author

does this work OK when sorting/grouping by due date?

Yes, changing sort order/grouping works fine

when something is due e.g. in 5m, will it tick down to 4m, 3m, etc?

Not quite, if the app is left open idling it won't update until the task (or any other task) is actually due. It updates when changing sorting and grouping, when fully close and reopen the app, and when holding down and selecting any task.
The widget doesn't update when left idling either. It updates with the same conditions as above.

Is there an update method that would need to be called more frequently for this to work better?

the actual strings probably need to be translated, and I'm not sure if it will just be %d%s for H, M, and D, or if there will need to be separate translations for each

I changed the return statement to return String.format(locale, "%d%s", num, unit); does that work?

@frknltrk
Copy link

frknltrk commented Mar 3, 2022

exciting! i've been literaly longing for this feature because the current default format doesn't really give a feeling of urgency. i believe this way is way more intuitive and definitely the best for the sake of user experience. #1449

@frknltrk
Copy link

frknltrk commented Apr 3, 2022

what is the situation about this pr? @abaker

@3ter
Copy link

3ter commented Sep 19, 2022

Wherever I've looked so far (e.g. Google News) the relative dates (here called "countdown") use lower case letters (m, h, d). This is also in sync with the units usually used.

The change isn't too big so far. The update behaviour should be looked into though, so that whenever the view is opened or changed the relative date is updated in addition to an update every minute when the view is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants