Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on lark>=1.0.0 #554

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Depend on lark>=1.0.0 #554

merged 1 commit into from
Jan 20, 2022

Conversation

mkniewallner
Copy link
Contributor

Before submitting your pull-request, make sure the following is done.

  • Fork the repository and create your branch from master so that it can be merged easily.
  • Update changelogs/next.md with your change (include reference to the issue & this PR).
  • Make sure all of the significant new logic is covered by tests. Not applicable
  • Make sure all quality checks are green (Gazr specification).

Description

lark-parser reached version 1.0.0 on November 2021.
None of the breaking changes appears to impact the codebase, but the package is now published as lark on PyPi instead of lark-parser.

Instead of pinning a specific version like we currently do, this PR also relaxes the requirement by allowing any 1.x minor version.
This would mostly be beneficial for projects having multiple dependencies that depend on lark.

We might also consider not setting any upper bound constraint at all, like a lot of projects recently started to do (see this article to understand a bit why).

@abusi abusi merged commit ca2fe2c into tartiflette:master Jan 20, 2022
@mkniewallner mkniewallner deleted the lark-stable branch January 20, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants