Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup.cfg to define most package metadata #537

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

mkniewallner
Copy link
Contributor

Before submitting your pull-request, make sure the following is done.

  • Fork the repository and create your branch from master so that it can be merged easily.
  • Update changelogs/next.md with your change (include reference to the issue & this PR). Not applicable
  • Make sure all of the significant new logic is covered by tests. Not applicable
  • Make sure all quality checks are green (Gazr specification).

Learn more about contributing

Define package metadata and requirements in setup.cfg, with regards to setuptools documentation, allowing to have declarative configuration which should be easier to maintain.

Tested in mkniewallner#5, with the source published here.
Taking the occasion to add python_requires and project_urls to the metadata, in order to have link to issues, source code, changelog and documentation directly from PyPI.
tests_require is removed because it's been deprecated in favor of extras_require (pypa/setuptools#1684)

Note that dependabot will continue to work as expected, as support for setup.cfg has been added a few months ago.

@abusi abusi merged commit e4b879f into tartiflette:master Oct 6, 2021
@mkniewallner mkniewallner deleted the use-setup-cfg branch October 6, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants