Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdist for functional tests #535

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

mkniewallner
Copy link
Contributor

Before submitting your pull-request, make sure the following is done.

  • Fork the repository and create your branch from master so that it can be merged easily.
  • Update changelogs/next.md with your change (include reference to the issue & this PR). Not applicable
  • Make sure all of the significant new logic is covered by tests. Not applicable
  • Make sure all quality checks are green (Gazr specification).

Learn more about contributing

tartiflette currently depends on pytest-xdist for test dependencies, but doesn't make use of it.
Passing -n auto to pytest for functional tests speeds up test durations both locally and on the CI.
As functional tests are isolated, it shouldn't cause any issue.

For unit tests, they are already rather fast, so it is not worth IMO to use multiple processes.

@abusi abusi merged commit 2c78051 into tartiflette:master Oct 6, 2021
@mkniewallner mkniewallner deleted the use-xdist-functional-tests branch January 8, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants