This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Builder default.nix logic #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8b5989
to
f29ee94
Compare
eccd66f
to
ab6535e
Compare
89b6fdd
to
19f2b19
Compare
19f2b19
to
1f73f45
Compare
|
@grahamc This is based on master now and can be reviewed independently. |
1f73f45
to
fa64be3
Compare
This should make it easier to see encoding issues.
We need a finer differentiation to implement the `default.nix` logic. Also add a bunch of comments to describe what is parsed in the first place.
For a directory import like `import ./foo`, nix imports
`./foo/default.nix` but only prints `./foo` to its log output.
This commit reproduces that behaviour.
We were watching way too many files, e.g. `import <nixpkgs> {}` meant
we’d watch all of nixpkgs recursively. This should be solved now.
Fixes #58
fa64be3
to
e7acd51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally solves the issue of watching way too many files. See commit messages for details.
Merge #117 first! Edit: the utf8-test will break, because it’s still broken on #117.Is now based on `master`.