Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #220 - Add notes sort option #313

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

vamshi-tg
Copy link
Contributor

@vamshi-tg vamshi-tg commented Mar 22, 2020

  • Trim after extracting the note's title
  • Fix test example

Description

Will add the following notes sort option

  • Title
  • Created Date
  • Last Updated Date
  • Favorites

Browser Checklist

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Safari

@vamshi-tg
Copy link
Contributor Author

@codytowstik @taniarascia, please let me know if this pr looks good or it requires any changes.

@vamshi-tg vamshi-tg closed this Mar 22, 2020
@vamshi-tg vamshi-tg reopened this Mar 22, 2020
* Trim after extracting the notes title
* Fix test example
@taniarascia
Copy link
Owner

This is great! I'll probably update some styles, and we're not using a _func convention for anything but dispatching, so I'll probably want to update that to be consistent as well, but otherwise looks good.

@taniarascia taniarascia merged commit 6b2e5aa into taniarascia:master Mar 22, 2020
@taniarascia
Copy link
Owner

@all-contributors please add @vamshi-tg for code

@allcontributors
Copy link
Contributor

@taniarascia

I've put up a pull request to add @vamshi-tg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Organizing notes - sort by various characteristics
2 participants