formatters_reformat_selection: handle case that nothing was selected #422
Conversation
| @@ -263,6 +263,9 @@ def formatters_reformat_last(formatters: str) -> str: | |||
| def formatters_reformat_selection(formatters: str) -> str: | |||
| """Reformats the current selection.""" | |||
| selected = edit.selected_text() | |||
| if not selected: | |||
| print("Asked to reformat selection, but nothing selected!") | |||
There was a problem hiding this comment.
We don't have a warning system to use for this kind of thing? If not then obv out of scope here but might be a useful thing to make at some point
There was a problem hiding this comment.
there is Python's logging.warning() but @knausj85 seemed to prefer print()?
There was a problem hiding this comment.
I'm fine with logging.warning - my suggestion on another PR was to open an issue so we remember switch to logging.warning more broadly if its useful to folks.
I previously hadn't really bothered since I run with zero output unless explicitly debugging something.
|
i am going to go ahead and merge this one as is, please open an issue if you guys feel we should move to using logging.warning etc broadly and we can get it done |
No description provided.