-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide dropdown border if no gradle tasks exists #451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the refactoring!
keelim
referenced
this pull request
in keelim/all
Jul 29, 2024
…to v1.25.0 (#1076) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | `1.24.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi:roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi:roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi:roborazzi/1.24.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi:roborazzi/1.24.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi:roborazzi)</summary> ### [`v1.25.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.25.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.24.0...1.25.0) ##### New Experimental Gradle Task: `clear` The Roborazzi Gradle Plugin saves image caches in `build/intermediates/roborazzi`. When users remove images in `build/outputs/roborazzi` and rerun the tests, it doesn't work as expected. To address this, we've added a Gradle task `clearRoborazziDebug` to remove all images. I'm gathering feedback about this task in [#​452](https://togithub.com/takahirom/roborazzi/issues/452). Please let me know if this causes any issues in your workflow. I'm aware that there are many different ways to use Roborazzi, and I'd like to improve your project workflow. ##### What's Changed - \[IDE Plugin] Hide dropdown border if no gradle tasks exists by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/451](https://togithub.com/takahirom/roborazzi/pull/451) Thank you for your contribution! - \[Feature] Add clear roborazzi task by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/453](https://togithub.com/takahirom/roborazzi/pull/453) **Full Changelog**: takahirom/roborazzi@1.24.0...1.25.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/keelim/all). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJVUERBVEUtbWlub3ItcGF0Y2giXX0=-->
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Jul 29, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.24.0` -> `1.25.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.24.0` -> `1.25.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.24.0` -> `1.25.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.24.0` -> `1.25.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.25.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.25.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.24.0...1.25.0) ##### New Experimental Gradle Task: `clear` The Roborazzi Gradle Plugin saves image caches in `build/intermediates/roborazzi`. When users remove images in `build/outputs/roborazzi` and rerun the tests, it doesn't work as expected. To address this, we've added a Gradle task `clearRoborazziDebug` to remove all images. I'm gathering feedback about this task in [#​452](https://togithub.com/takahirom/roborazzi/issues/452). Please let me know if this causes any issues in your workflow. I'm aware that there are many different ways to use Roborazzi, and I'd like to improve your project workflow. ##### What's Changed - \[IDE Plugin] Hide dropdown border if no gradle tasks exists by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/451](https://togithub.com/takahirom/roborazzi/pull/451) Thank you for your contribution! - \[Feature] Add clear roborazzi task by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/453](https://togithub.com/takahirom/roborazzi/pull/453) **Full Changelog**: takahirom/roborazzi@1.24.0...1.25.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45LjAiLCJ1cGRhdGVkSW5WZXIiOiIzOC45LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->
chrisbanes
referenced
this pull request
in chrisbanes/haze
Aug 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | `1.23.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | `1.23.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi:roborazzi-junit-rule/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi:roborazzi-junit-rule/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi:roborazzi-junit-rule/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi:roborazzi-junit-rule/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose-desktop](https://togithub.com/takahirom/roborazzi) | `1.23.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi:roborazzi-compose-desktop/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi:roborazzi-compose-desktop/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi:roborazzi-compose-desktop/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi:roborazzi-compose-desktop/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | `1.23.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi:roborazzi-compose/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi:roborazzi-compose/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi:roborazzi-compose/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi:roborazzi-compose/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | `1.23.0` -> `1.25.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.takahirom.roborazzi:roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.takahirom.roborazzi:roborazzi/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.takahirom.roborazzi:roborazzi/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.takahirom.roborazzi:roborazzi/1.23.0/1.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.25.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.25.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.24.0...1.25.0) ##### New Experimental Gradle Task: `clear` The Roborazzi Gradle Plugin saves image caches in `build/intermediates/roborazzi`. When users remove images in `build/outputs/roborazzi` and rerun the tests, it doesn't work as expected. To address this, we've added a Gradle task `clearRoborazziDebug` to remove all images. I'm gathering feedback about this task in [#​452](https://togithub.com/takahirom/roborazzi/issues/452). Please let me know if this causes any issues in your workflow. I'm aware that there are many different ways to use Roborazzi, and I'd like to improve your project workflow. ##### What's Changed - \[IDE Plugin] Hide dropdown border if no gradle tasks exists by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/451](https://togithub.com/takahirom/roborazzi/pull/451) Thank you for your contribution! - \[Feature] Add clear roborazzi task by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/453](https://togithub.com/takahirom/roborazzi/pull/453) **Full Changelog**: takahirom/roborazzi@1.24.0...1.25.0 ### [`v1.24.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.24.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.23.0...1.24.0) ##### New feature: Support for includePrivatePreviews in Compose Preview Support Compose Preview Support, initially released in version 1.22.0, now includes the `includePrivatePreviews` option. This feature allows you to include private previews in your Compose Preview Support setup. You can enable this by setting `includePrivatePreviews` in `roborazzi.generateComposePreviewRobolectricTests.includePrivatePreviews`. Thank you for submitting this feature request, [@​yuchan2215](https://togithub.com/yuchan2215) ! ##### New feature: JUnit rule support in ComposePreviewTester We've enhanced ComposePreviewTester to support JUnit rules. Previously, ComposePreviewTester lacked lifecycle hooks, which made certain scenarios challenging to handle. Now, you can pass your own Test rules, including your Compose Test Rule, and use them in tests. For a sample implementation, check out [this integration test](https://togithub.com/takahirom/roborazzi/blob/2519f46ec0e5a8dadc5139ae833e2925c90c8b21/include-build/roborazzi-gradle-plugin/src/integrationTest/projects/sample-generate-preview-tests/src/test/java/com/github/takahirom/sample/CustomPreviewTester.kt). ##### Breaking changes for users of the `ComposePreviewTester` interface As we continue to improve Compose Preview Support, we've made some changes to the `ComposePreviewTester` interface. These changes introduce a breaking change for current users. ComposePreviewTester is an interface for modifying the behavior of Compose Preview Support. Previously, the API was prone to breaking changes with each new option added. We've addressed this issue by introducing a new `options()` function. However, this necessitates a change in how you use the interface. Old interface: ```kotlin fun previews(vararg packages: String): List<ComposablePreview<T>> ``` New interface (Packages can now be accessed via `options().scanOptions.packages`): ```kotlin fun previews(): List<ComposablePreview<T>> ``` ##### Acknowledgments We'd like to extend our sincere thanks to [@​yschimke](https://togithub.com/yschimke) and [@​sergio-sastre](https://togithub.com/sergio-sastre) for their valuable design reviews and insightful feedback, which greatly contributed to the improvements in this release. ##### What's Changed - \[Idea Plugin] Improve performance of idea plugin by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/439](https://togithub.com/takahirom/roborazzi/pull/439) - \[Idea Plugin] Prepare for release of IntelliJ IDEA plugin by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/442](https://togithub.com/takahirom/roborazzi/pull/442) - \[Idea Plugin] Tweak idea plugin UI by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/443](https://togithub.com/takahirom/roborazzi/pull/443) - \[Feature, Breaking Changes] Support includePrivatePreviews of ComposablePreviewScanner by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/445](https://togithub.com/takahirom/roborazzi/pull/445) - \[Docs] Add mention to the sample in Compose Preview Support document by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/448](https://togithub.com/takahirom/roborazzi/pull/448) - \[Docs] Fix URL of the README link by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/449](https://togithub.com/takahirom/roborazzi/pull/449) **Full Changelog**: takahirom/roborazzi@1.23.0...1.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/chrisbanes/haze). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450.
Screenshot