Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] 鈾伙笍 Added the ability to check the path of locally output images. #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Corvus400
Copy link

Motivation for issuing this PR.

I thought it would be useful to have the ability to see where the images are stored when responding to the following PRs.馃檹
DroidKaigi/conference-app-2023#1090

@takahirom
Copy link
Owner

takahirom commented Sep 6, 2023

Thank you for the PR! If we add it here, we'll need to keep track of this variable in various places, making management challenging. I'm torn, but for now, I think the following approach might be better. What do you think?
https://github.com/takahirom/roborazzi#q-my-screenshot-tests-are-not-capturing-images-what-could-be-the-issue

@Corvus400
Copy link
Author

Sorry, I made a correction to the test before checking the comments, so I'll revise it again based on your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants