Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output unparsable values #6469

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Don't output unparsable values #6469

merged 3 commits into from
Dec 13, 2021

Conversation

thecrypticace
Copy link
Contributor

We do two things here:

  1. Validate that arbitrary properties result in actual parsable css declarations
  2. Ignore malformed css properties (for example beginning with a number)

This prevents generation of classes for things like [0:02] or [autoplay:${autoplay}] which result in invalid css. This does not fix all cases but should help significantly.

Fixes #6395

@thecrypticace thecrypticace merged commit 399440e into master Dec 13, 2021
@thecrypticace thecrypticace deleted the fix/unparsable-values branch December 13, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abnormal css ouput when some string in the code is wrapped in square brackets
1 participant