Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'text-decoration-color' to default 'transition' and 'transition-colors' utilities #6405

Merged
merged 9 commits into from
Dec 15, 2021

Conversation

fekle
Copy link
Contributor

@fekle fekle commented Dec 11, 2021

Hi there!

In this pull request I added the text-decoration-color property to the default options for transition and transition-colors utilities, as tailwindcss v3 introduced support for underline styles.

As it is right now when the underline color differs from the text color, say it is transparent by default and black on hover, transition and transition-colors only enable transition on the text color itself, but not on the underline color.

I'm not sure if this was intended, but in my opinion it makes sense to also transition the text-decoration-color property by default.
Or maybe it would be better to add a new transition-text-decoration property?

I updated all test files to reflect those changes, and all tests pass.

@reinink reinink merged commit 9934174 into tailwindlabs:master Dec 15, 2021
@reinink
Copy link
Member

reinink commented Dec 15, 2021

@fekle Good catch! Thanks for submitting this PR 🙏

@fekle
Copy link
Contributor Author

fekle commented Dec 15, 2021

No worries, thanks for merging!
Sorry about those tailwind-output-* files in the fixtures, they were a part of master when i created the PR.

@reinink
Copy link
Member

reinink commented Dec 15, 2021

@fekle All good, it was a good reminder to actually remove these, as they are no longer used: 0783a42

Also, FYI, I also switched the order of the color and text-decoration-color properties: 1c7a793

@fekle
Copy link
Contributor Author

fekle commented Dec 15, 2021

@reinink ah, good to know. I wasn't sure how to order them, since not the entire list is ordered alphabetically, so I assumed that the 'longer' color attributes like text-decoration-color and border-color came before the base color attribute. But I guess it doesn't matter much in the end :)

@reinink
Copy link
Member

reinink commented Dec 15, 2021

Yeah, oops, I meant to put color first, and then do alphabetical after that. Updated that now: ec911c7

And you're right, doesn't really matter in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants