Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI --content option #5775

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Fix CLI --content option #5775

merged 2 commits into from
Oct 13, 2021

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented Oct 13, 2021 •
edited
Loading

This PR fixes the CLI --content option. Following resolution the content config looks like this, so it's actually content.files that needs updating:

{
  files: [],
  extract: {
    DEFAULT: undefined
  },
  transform: {}
}

Side note: is extract.DEFAULT supposed to be undefined here? 馃 See #5778

RobinMalfait
RobinMalfait approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's a good catch! Also thanks for adding a test!

@bradlc bradlc merged commit 92df04d into master Oct 13, 2021
@bradlc bradlc deleted the fix-cli-content branch October 13, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradlc @RobinMalfait