Add fit-content utilities for (min/max) height and width #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good thanks! I'm open to adding min/max content utilities in the other places where it makes sense too if you feel like PRing those 👍🏻 Previously we left things out for file size considerations but not a problem anymore. |
45 tasks
|
I don't see 'fit-content'. Was this merged and integrated into Tailwind? I had to use |
|
@samheyman yes it's there by default. It won't be there if you overrode the values in your tailwind config file so make sure to double check that. Checkout the generated tab at the bottom: https://play.tailwindcss.com/rzPIBlnfH2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fit-content classes for (min/max) height and width.
I noticed only width seemed to have min or max content utilities currently. I'm not sure why height is missing them but I left it that way to keep this PR focussed. Happy to make a follow up if they are wanted too.
Couldn't find relevant tests for the existing utils for width and height so haven't added any for this. Feel free to point me in the right direction and I can add them.