Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply configured prefix to the .group class for group-hover variants #1216

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

adamwathan
Copy link
Member

Fixes #1215, so now if you configure a prefix like tw-, group-hover variants will include the prefix on the .group portion:

<!-- Before -->
<div class="group">
  <div class="group-hover:tw-bg-blue-500">...</div>
</div>

<!-- After -->
<div class="tw-group">
  <div class="group-hover:tw-bg-blue-500">...</div>
</div>

This is one of those "bug fix but also breaking change for anyone who was working around the bug" patches :/

Let me know if this change impacts your project, if the impact is widespread enough maybe we will just live with this bug until 2.0.

@superhighfives
Copy link

Just came across this one in a new project—I wonder if a fix could be an opt-in via config, and then baked in for v2.0? Just a thought!

@adamwathan adamwathan merged commit e376f94 into next-patch Nov 25, 2019
@adamwathan
Copy link
Member Author

Think I'm just gonna call it a bugfix and push out a patch 😞It definitely is a bug but yeah situation still sucks.

I could double up the selector and have it generate stuff like:

.group:hover .group-hover\:tw-bg-blue-500,
.tw-group:hover .group-hover\:tw-bg-blue-500 {
  // ...
}

...but that sucks too and introduces some cruft. Bleh. Next time I will just try not to make mistakes.

@superhighfives
Copy link

Ah, it happens! I wouldn't beat yourself up over it. More importantly—thanks for making such an awesome framework. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants