Improve CSS output in tests to better reflect reality #10454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the expected CSS output in our tests. We are now using lightning css which produces
a more optimized CSS output.
Right now the tests are setup in a way that both the generated css and expected css are run through
lightningcss
to make sure that the output is concistent for thestable
andoxide
engines. But this also means that the expected output could be larger (aka not optimized) and still matches (after it runs through lightningcss).By replacing this with the more optimal output we achieve a few things:
lightningcss
.Lightning CSS makes use of the browserslist, currently for our tests we told it to use
Chrome v106
. This is also the reason why certain things are squashed now:Before:
After:
Also important to note that this PR doesn't touch actual implementation. Just test output, that way we can know for sure that we didn't break anything because we didn't update code + tests 👍