Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hyphens #10071

Merged
merged 1 commit into from
Feb 7, 2023
Merged

feat: add hyphens #10071

merged 1 commit into from
Feb 7, 2023

Conversation

fratzinger
Copy link
Contributor

In german language we have many long words. We concat cohesive words without whitespaces. It's pretty easy to have words with 15+ characters. The german language also has strict rules how to hyphenate based on syllables, so the https://tailwindcss.com/docs/word-break does not help at all for normal language.

So the hyphens rule comes in pretty handy: https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens

It's pretty straight forward addition, that's requested by a few people:

@Danielduel
Copy link

LGTM 👍

https://caniuse.com/?search=hyphens
The core support looks like it's done, but per-nonenglish-language support is only on Firefox.

@adamwathan
Copy link
Member

Thanks! The much bigger project here is the documentation. If anyone wants to put together a PR for that against our v3.3 branch in the docs repo that will make it faster to merge this. Challenge is always coming up with nice visual examples that teach the feature well.

@fratzinger
Copy link
Contributor Author

Thanks for the quick reaction.

I've started but am not able to get the right version of the dependency to work on the docs properly. What's the insiders version of tailwindcss of this branch? How do I get this up and running so it can be reviewed? Unfortunately, I haven't found a contribution guide which describes the workflow. Guidance is highly appreciated, so I'm able to make a PR against the v3.3 branch in the docs repo. 👍

@adamwathan
Copy link
Member

Just gonna merge this for now, I'll get the docs ready before the real v3.3 release some time in March. Thanks!

@adamwathan adamwathan merged commit f58a43f into tailwindlabs:master Feb 7, 2023
RobinMalfait added a commit that referenced this pull request Feb 8, 2023
RobinMalfait added a commit that referenced this pull request Feb 8, 2023
* Revert "add caption-side utilities (#10470)"

This reverts commit f395cc4.

* Revert "Add support for configuring default `font-variation-settings` for a `font-family` (#10515)"

This reverts commit 8bd2846.

* Revert "feat: add hyphens (#10071)"

This reverts commit f58a43f.

* Revert "Add logical properties support for inline direction"

* Revert "Add `delay-0` and `duration-0` by default"

* Revert "Support using variables as arbitrary values without `var()`"

* Revert "Add `line-height` modifier support to `font-size` utilities"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants