Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial github-actions-based tests #548

Merged
merged 9 commits into from
Dec 22, 2021
Merged

Initial github-actions-based tests #548

merged 9 commits into from
Dec 22, 2021

Conversation

tailhook
Copy link
Owner

@tailhook tailhook commented Oct 8, 2021

No description provided.

@tailhook tailhook force-pushed the github_tests branch 2 times, most recently from 40e7ad1 to 8ef5811 Compare October 9, 2021 11:29
@tailhook tailhook force-pushed the github_tests branch 2 times, most recently from 8d4fbc9 to da53f39 Compare December 18, 2021 17:11
@anti-social
Copy link
Contributor

Think we should use vagga to build itself as for instance for #555 we'll need to compile openssl statically.

@anti-social
Copy link
Contributor

Have you any thoughts why does "image: pull & push" test fail? On my computer it passes.

@tailhook
Copy link
Owner Author

Think we should use vagga to build itself as for instance for #555 we'll need to compile openssl statically.

I'm not sure what is the difference.

Have you any thoughts why does "image: pull & push" test fail? On my computer it passes.

No idea. We have to make more debugging in the test.

@anti-social
Copy link
Contributor

I'm not sure what is the difference.

To not duplicate setup code from a build container into github-ci. For instance to install openssl we'll need to add something like:

    # https://qiita.com/liubin/items/6c94f0b61f746c08b74c
    - !Sh |
        ln -s /usr/include/x86_64-linux-gnu/asm /usr/include/x86_64-linux-musl/asm
        ln -s /usr/include/asm-generic /usr/include/x86_64-linux-musl/asm-generic
        ln -s /usr/include/linux /usr/include/x86_64-linux-musl/linux
    - !TarInstall
      url: https://github.com/openssl/openssl/archive/OpenSSL_1_1_1l.tar.gz
      script: |
        CC="musl-gcc -fPIE -pie" \
          ./Configure no-shared no-async \
          --prefix=/usr/lib/x86_64-linux-musl \
          --openssldir=/usr/lib/x86_64-linux-musl/ssl \
          linux-x86_64
        make depend
        make -j$(nproc)
        make install_sw

But possibly it's not a problem at all.

@tailhook
Copy link
Owner Author

I'm not sure what is the difference.

To not duplicate setup code from a build container into github-ci. For instance to install openssl we'll need to add something like:

Yes, I think that's not a problem. Although, if rust-cache works for vagga-based builds, we can probably go either way.

@tailhook tailhook merged commit e51916a into master Dec 22, 2021
@tailhook tailhook deleted the github_tests branch December 22, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants