Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jit): support introspection in JIT #2769

Merged
merged 33 commits into from
Aug 30, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 29, 2024
@laststylebender14 laststylebender14 marked this pull request as draft August 29, 2024 06:20
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 79.68750% with 26 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (075e1f8) to head (5cf9433).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/graphql_executor.rs 36.66% 19 Missing ⚠️
src/core/jit/model.rs 75.00% 3 Missing ⚠️
src/core/lift.rs 0.00% 3 Missing ⚠️
src/core/jit/builder.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
- Coverage   86.80%   86.76%   -0.04%     
==========================================
  Files         254      254              
  Lines       25026    25147     +121     
==========================================
+ Hits        21723    21818      +95     
- Misses       3303     3329      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review August 29, 2024 07:22
@laststylebender14 laststylebender14 added the ci: test-jit Run all integration tests for the JIT optimized engine label Aug 29, 2024
@laststylebender14 laststylebender14 marked this pull request as draft August 29, 2024 07:47
@laststylebender14 laststylebender14 marked this pull request as ready for review August 29, 2024 11:21
src/core/jit/request.rs Outdated Show resolved Hide resolved
src/core/jit/model.rs Outdated Show resolved Hide resolved
src/core/jit/model.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath changed the title fix(jit): execute introspection request with async_graphql feat(jit): support introspection in JIT Aug 30, 2024
@tusharmath tusharmath added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. and removed type: fix Iterations on existing features or infrastructure. labels Aug 30, 2024
@tusharmath tusharmath enabled auto-merge (squash) August 30, 2024 08:45
@tusharmath tusharmath merged commit bbd6d4d into main Aug 30, 2024
27 of 30 checks passed
@tusharmath tusharmath deleted the fix/execute-introspection-requests-with-async_graphql branch August 30, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: test-jit Run all integration tests for the JIT optimized engine type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants