Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2560): merge unknows types #2567

Merged
merged 24 commits into from
Aug 28, 2024
Merged

feat(2560): merge unknows types #2567

merged 24 commits into from
Aug 28, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Jul 28, 2024 •
edited
Loading

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2560
/claim #2560

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Jul 28, 2024
Closed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 28, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jul 28, 2024
@laststylebender14 laststylebender14 marked this pull request as draft July 28, 2024 16:06
@laststylebender14 laststylebender14 marked this pull request as ready for review July 28, 2024 16:55
@codecov Codecov
Copy link

codecov bot commented Jul 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (751e9a6) to head (b0bca8f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
+ Coverage   86.17%   86.21%   +0.04%     
==========================================
  Files         255      255              
  Lines       25030    25105      +75     
==========================================
+ Hits        21570    21645      +75     
  Misses       3460     3460

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath assigned tusharmath and unassigned tusharmath Jul 31, 2024
@tusharmath tusharmath marked this pull request as draft July 31, 2024 04:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 5, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 19, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 24, 2024
@laststylebender14 laststylebender14 removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 28, 2024
@laststylebender14 laststylebender14 changed the title feat: merge unknows types feat(2560): merge unknows types Aug 28, 2024
@laststylebender14 laststylebender14 marked this pull request as ready for review August 28, 2024 13:10
@tusharmath tusharmath enabled auto-merge (squash) August 28, 2024 15:49
@tusharmath tusharmath merged commit aa669c4 into main Aug 28, 2024
36 checks passed
@tusharmath tusharmath deleted the feat/treat-unknow-types-same branch August 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karatakis karatakis karatakis left review comments

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer Inferred Types over unknown types While Merging When Two Types Have Similar Fields
3 participants
@laststylebender14 @tusharmath @karatakis