-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: re-write gen_gql_schema.rs #2297
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
@tusharmath ready for review |
Is there a way to ensure nothing changed semantically between the previous and the current |
There are only a few tiny comments on this PR. Overall it looks awesome and is a massive improvement over our current approach 🙌 Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention. |
The order of some types are a bit different what I did is I re-ordered the types in the generated file manually to match the old one it took a couple of minutes, removed all the white spaces and new lines from both files and computed the hash, they both gave the same hash means they both got the same results. If you would to do the same you should get these results.
note there was a slight issue in the previous generated file due to : so you will have to update that in the old generated file to get the same hash |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
==========================================
+ Coverage 86.02% 87.41% +1.38%
==========================================
Files 234 240 +6
Lines 22405 22448 +43
==========================================
+ Hits 19274 19622 +348
+ Misses 3131 2826 -305 ☔ View full report in Codecov by Sentry. |
Well done! @bnchi |
Summary:
note: the order in which the types show up in the file is a bit different from the old one, but I re-ordered them manually and computed the SHA of the old and the new file to see if there's any difference in the content, and they both gave the same hash.
Issue Reference(s):
Fixes #1510
/claim #1510
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>