Replace zip with zip_next
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you notice any performance impact? |
|
I haven't run the benchmarks, but I can assure you that a regression is highly unlikely. |
|
As the update in zip_next come back to zip, maybe we can replace zip_next back with zip 1.0 @Pr0methean |
|
Smart move. I was invited to take over the |
|
They already have; `zip-next` is now a wrapper around `zip`, published from
the same repository as `zip-next` used to be published from.
…On Tue, Apr 30, 2024, 00:36 Dirreck ***@***.***> wrote:
As the update in zip_next come back to zip, maybe we can replace zip_next
back with zip 1.0 @Pr0methean <https://github.com/Pr0methean>
—
Reply to this email directly, view it on GitHub
<#423 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABF3NBLLLDVYNPSU6KTECVTY75CZVAVCNFSM6AAAAABGBAITBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGU4TSMRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zipcrate hasn't been updated in almost a year, and has a number of bugs that can cause panics when trying to process an invalid zip file. This PR replaces it withzip_next, a fork I actively maintain.