Fix incomplete deviceinfo (danielpaulus#22)

* fix ios info by returning the full plist

* return "value" object of the response instead of the whole response

ios/lockdown_value.go

@@ -208,6 +208,23 @@ func getAllValuesResponseFromBytes(plistBytes []byte) GetAllValuesResponse {
 	return getAllValuesResponse
 }
 
+//GetValuesPlist returns the full lockdown values response as a map, so it can be converted to JSON easily.
+func GetValuesPlist(device DeviceEntry) (map[string]interface{}, error) {
+	lockdownConnection := ConnectLockdownWithSession(device)
+	defer lockdownConnection.Close()
+	lockdownConnection.Send(newGetValue(""))
+	resp, err := lockdownConnection.ReadMessage()
+	if err != nil {
+		return map[string]interface{}{}, err
+	}
+	plist, err := ParsePlist(resp)
+	plist, ok := plist["Value"].(map[string]interface{})
+	if !ok {
+		return plist, fmt.Errorf("Failed converting lockdown response:%+v", plist)
+	}
+	return plist, err
+}
+
 //GetValues returns all values of deviceInformation from lockdown
 func GetValues(device DeviceEntry) GetAllValuesResponse {
 	lockdownConnection := ConnectLockdownWithSession(device)

ios/utils.go

@@ -53,7 +53,7 @@ func GetDevice(udid string) (DeviceEntry, error) {
 		if len(deviceList.DeviceList) == 0 {
 			return DeviceEntry{}, errors.New("no iOS devices are attached to this host")
 		}
-		log.WithFields(log.Fields{"udid": deviceList.DeviceList[0].Properties.SerialNumber}).Info("no udid specified using default")
+		log.WithFields(log.Fields{"udid": deviceList.DeviceList[0].Properties.SerialNumber}).Debug("no udid specified using default")
 		return deviceList.DeviceList[0], nil
 	}
 	for _, device := range deviceList.DeviceList {

main.go

@@ -549,8 +549,11 @@ func startListening() {
 }
 
 func printDeviceInfo(device ios.DeviceEntry) {
-	allValues := ios.GetValues(device)
-	fmt.Println(convertToJSONString(allValues.Value))
+	allValues, err := ios.GetValuesPlist(device)
+	if err != nil {
+		failWithError("failed getting info", err)
+	}
+	fmt.Println(convertToJSONString(allValues))
 }
 
 func runSyslog(device ios.DeviceEntry) {
@@ -603,3 +606,7 @@ func convertToJSONString(data interface{}) string {
 	}
 	return string(b)
 }
+
+func failWithError(msg string, err error) {
+	log.WithFields(log.Fields{"err": err}).Fatalf(msg)
+}