Various tailwind fixes #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add custom publish script to build before publishing
t3dotgg
reviewed
Jul 4, 2022
| <a target="_blank">Learn More</a> | ||
| </Link> | ||
| </button> | ||
| <section className="h-full transform group border-2 border-neutral-800 rounded-2xl duration-300 hover:scale-105 hover:border-blue-600 hover:-translate-y-1 hover:shadow-2xl"> |
There was a problem hiding this comment.
Is hover:-translate-y correct? The extra - at the beginning in particular
There was a problem hiding this comment.
I believe so - its just a negative value in tailwind, i.e. negative margin on hover would be hover:-mt-8. It's from the initial tailwind styles, not my code so I'm not 100% confident.
t3dotgg
approved these changes
Jul 4, 2022
|
We have some merge conflicts. Take a look at #89 |
|
Closing per nexxel to hopeful making merging easier. Will submit a new PR. |
This was referenced Jul 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve the default
index.tsxpage.<Link>component<section>to<main>for better semanticsThis is my first contribution to the project, hopefully everything looks okay!