Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always include .env and .env.example #901

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Conversation

c-ehrlich
Copy link
Member

Closes #871

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • rename NEXT_PUBLIC_BAR to NEXT_PUBLIC_CLIENTVAR as it's more descriptive and we are already using this name in the docs anyway
  • include a sample .env and .env.example file in all apps, even ones that don't need any env vars initially
  • include schema files with those apps as well
  • i'm leaning towards this feature but would be ok not merging if it's decided that we don't want this. the way i see it is that the downside is more files in a base app, and the upside is communicating more clearly our default env strategy.

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2022

🦋 Changeset detected

Latest commit: e816eed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 7:15PM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Nov 30, 2022
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to add this new file, just make any necessary modifications here https://github.com/t3-oss/create-t3-app/blob/next/cli/template/base/src/env/schema.mjs

cli/template/addons/env/base-schema.mjs Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-env-always-t3-oss.vercel.app/

@juliusmarminge juliusmarminge enabled auto-merge (squash) December 2, 2022 00:27
@juliusmarminge juliusmarminge merged commit 9b6ae5c into next Dec 2, 2022
@juliusmarminge juliusmarminge deleted the env-always branch December 2, 2022 00:27
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: No .env.example in some templates
2 participants