Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in auth-schema.mjs #845

Closed
wants to merge 2 commits into from

Conversation

GabrielPedroza
Copy link
Contributor

Simple fix. Won't break anything

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

πŸ’―

Simple fix. Won't break anything
@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2022

⚠️ No Changeset found

Latest commit: 698dbbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Nov 27, 2022 at 0:04AM (UTC)

@github-actions github-actions bot added πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App labels Nov 23, 2022
@GabrielPedroza
Copy link
Contributor Author

i know it's small but it was bugging me a bit

@AyanavaKarmakar
Copy link
Contributor

This one needs to be changed too

// VERCEL_URL doesnt include `https` so it cant be validated as a URL

Maybe update NextAuth => NextAuth.js while you're at it

// Since NextAuth automatically uses the VERCEL_URL if present.

This one too

// Since NextAuth automatically uses the VERCEL_URL if present.

Also, you need to add a changeset for CLI changes

@nexxeln nexxeln changed the title Update typo in auth-schema.mjs fix: typo in auth-schema.mjs Nov 23, 2022
Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @AyanavaKarmakar said

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2022

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟒 Performance 100
🟒 Accessibility 100
🟒 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-gabrielpedroza-patch-2-t3-oss.vercel.app/

@juliusmarminge juliusmarminge mentioned this pull request Nov 27, 2022
3 tasks
@juliusmarminge
Copy link
Member

Superseded by #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants