Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): i18n stuff #820

Merged
merged 45 commits into from
Dec 2, 2022
Merged

feat(docs): i18n stuff #820

merged 45 commits into from
Dec 2, 2022

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Nov 21, 2022 •
edited
Loading

Resolves #821, #792

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Some more preparations for getting translations online

  • show table of contents for active language
  • sidebar can be translated
  • a lot of styling fixes for rtl languages

Will require more work in the future, but i think it makes sense to merge WIP occasionally

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 281ad69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
create-t3-app ⬜️ Ignored (Inspect) Dec 2, 2022 at 0:28AM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-left-sidebar-language-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member

Could have just continued on my PR :(

@c-ehrlich c-ehrlich changed the title feat: left sidebar language feat(docs): left sidebar language Nov 21, 2022
@c-ehrlich
Copy link
Member Author

Could have just continued on my PR :(

oh yeah my bad :/

feel free to merge this into your pr and close

@JohnBakhmat
Copy link
Contributor

I think parsing a titles from tanslation pages would be better then using constant with paths and labels

@c-ehrlich
Copy link
Member Author

I think parsing a titles from tanslation pages would be better then using constant with paths and labels

i agree this would be better, but can't think of an easy way to do it currently. only way i can think of is to import every article in each language in config.ts and get frontmatter from all of them, which is a lot. maybe there's something to help us in astro docs, can check tonight.

@c-ehrlich c-ehrlich mentioned this pull request Nov 21, 2022
Closed
@c-ehrlich c-ehrlich changed the title feat(docs): left sidebar language feat(docs): i18n stuff Nov 23, 2022
@c-ehrlich
Copy link
Member Author

also dont merge before arabic is removed from the list of known languages, otherwise we're deploying two fake arabic pages

@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Nov 29, 2022
@c-ehrlich
Copy link
Member Author

c-ehrlich commented Nov 30, 2022 •
edited
Loading

@juliusmarminge lmk when you're ready to merge and i'll remove the arabic placeholder stuff (or feel free to remove it yourself)

@c-ehrlich c-ehrlich mentioned this pull request Nov 30, 2022
Merged
22 tasks
juliusmarminge
juliusmarminge requested changes Nov 30, 2022
View reviewed changes
.changeset/heavy-buckets-try.md Outdated Show resolved Hide resolved
juliusmarminge
juliusmarminge approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool lets ship

@juliusmarminge juliusmarminge enabled auto-merge (squash) December 1, 2022 19:21
@juliusmarminge juliusmarminge merged commit a4d4ee8 into next Dec 2, 2022
@juliusmarminge juliusmarminge deleted the left-sidebar-language branch December 2, 2022 00:30
@JohnBakhmat JohnBakhmat mentioned this pull request Dec 26, 2022
Merged
3 tasks
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@c-ehrlich @juliusmarminge
feat(docs): i18n stuff (t3-oss#820)
f312982 
* links in left sidebar use active language

* add ToC for in progress translations

* prettier

* github icon rtl

* implement getIsRtlFromUrl

* navbar rtl fix

* gap in search

* use isLtr

* code blocks are always ltr

* leftSidebar has scrollbar on right side ltr&rtl

* arabic sample files

* more rtl styling

* fix merge conflict

* fix missing '!'

* prettier

* use padding-start

* css cleanup

* more direction-independent classes

* rtl spacing stuff

* fix lists and tables in rtl

* fix avatar in quotes (but should be a component)

* prettier

* fix code embeds having rtl punctuation

* slightly less awful nativeHeader type

* prettier

* outdated docs ltr + mx

* prettier

* fix ts-errors

* add todo

* chore: add changeset

* remove changeset

Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: the side menu href to the en docs when the locale is arabic
3 participants
@c-ehrlich @juliusmarminge @JohnBakhmat