Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new index #711

Merged
merged 12 commits into from
Nov 16, 2022
Merged

feat: new index #711

merged 12 commits into from
Nov 16, 2022

Conversation

c-ehrlich
Copy link
Member

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • new index page
  • nicer styling
  • invites users to check out our quick start guide and/or docs
  • same tRPC and auth demos
  • much shorter index.tsx files than before (42-82 lines depending on chosen packages)

The links are to the new docs, without beta in the URL - so don't merge until after the new docs are live!


Screenshots

All packages selected
Screenshot 2022-11-08 at 21 56 46

No packages selected
Screenshot 2022-11-08 at 21 56 51

Mobile
Screenshot 2022-11-08 at 21 57 47

πŸ’―

@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Nov 16, 2022 at 5:29PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

πŸ¦‹ Changeset detected

Latest commit: 476df03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

⚑️ Lighthouse report for the changes in this PR:

Category Score
πŸ”΄ Performance 47
🟒 Accessibility 98
🟒 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-new-index2-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member

There might be links in the readme too pointing towards the beta

@juliusmarminge juliusmarminge added the πŸš€ autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@juliusmarminge juliusmarminge removed the πŸš€ autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2022

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

@juliusmarminge juliusmarminge added the πŸš€ autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
@github-actions github-actions bot removed the πŸš€ autorelease add this label to a pr to trigger a beta release label Nov 13, 2022
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-11-13 at 02 42 45@2x

This is text-2xl on the trpc message and px-10 on the Sign In button

cli/template/page-studs/index/with-auth-trpc-tw.tsx Outdated Show resolved Hide resolved
cli/template/page-studs/index/with-auth-trpc-tw.tsx Outdated Show resolved Hide resolved
@c-ehrlich
Copy link
Member Author

Agreed, both changes look better. I also shortened the secret message a bit

image

Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAA IM SO EXCITED

@nexxeln nexxeln merged commit da760c7 into next Nov 16, 2022
@nexxeln nexxeln deleted the new-index2 branch November 16, 2022 17:34
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* new index

* fix missing closing tag

* no margin on headings

* feat: add changeset

* bigger text and wider button (css module)

* bigger text and wider button (tailwind)

* shorter secret message

Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants