Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add "first steps" page and reduce h3 spacing #703

Merged
merged 17 commits into from
Nov 8, 2022
Merged

docs: add "first steps" page and reduce h3 spacing #703

merged 17 commits into from
Nov 8, 2022

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Nov 7, 2022 •
edited

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Add "first steps" page to the docs (let me know how yall feel about this - I made it because I think it would be good to have a link to a "everything you need for db and auth to work" page in the template index.tsx)
  • Reduce the ridiculous h3 top margin

💯

@vercel
Copy link

vercel bot commented Nov 7, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 7:18PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022 •
edited

⚠️ No Changeset found

Latest commit: 441d557

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-getting-started-t3-oss.vercel.app/

nexxeln
nexxeln requested changes Nov 8, 2022
View reviewed changes
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
www/src/pages/en/usage/first-steps.md Show resolved Hide resolved
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
@juliusmarminge
Copy link
Member

juliusmarminge commented Nov 8, 2022 •
edited

Can we do smth bout the "More" menu on mobile?

  • bit more spacing
  • centering? (Prob not)

image

AyanavaKarmakar
AyanavaKarmakar suggested changes Nov 8, 2022
View reviewed changes
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
@c-ehrlich @AyanavaKarmakar
call it NextAuth
7aac7e5 
Co-authored-by: Ayanava Karmakar <[email protected]>
@c-ehrlich @AyanavaKarmakar
here also
42bab8b 
Co-authored-by: Ayanava Karmakar <[email protected]>
AyanavaKarmakar
AyanavaKarmakar suggested changes Nov 8, 2022
View reviewed changes
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
AyanavaKarmakar
AyanavaKarmakar suggested changes Nov 8, 2022
View reviewed changes
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
www/src/pages/en/usage/first-steps.md Outdated Show resolved Hide resolved
@c-ehrlich
Copy link
Member Author

i cant figure out which review is still open :/

@juliusmarminge
Copy link
Member

me neither xd

@juliusmarminge juliusmarminge merged commit 02947f5 into next Nov 8, 2022
@juliusmarminge juliusmarminge deleted the getting-started branch November 8, 2022 19:53
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
@c-ehrlich @nexxeln
@AyanavaKarmakar @juliusmarminge
docs: add "first steps" page and reduce h3 spacing (t3-oss#703)
f651e9f 
* reduce h3 top margin

* add "first steps" page to docs

* prettier

* Update www/src/pages/en/usage/first-steps.md

Co-authored-by: Shoubhit Dash <[email protected]>

* call it NextAuth

Co-authored-by: Ayanava Karmakar <[email protected]>

* here also

Co-authored-by: Ayanava Karmakar <[email protected]>

* Update www/src/pages/en/usage/first-steps.md

Co-authored-by: Ayanava Karmakar <[email protected]>

* Update www/src/pages/en/usage/first-steps.md

Co-authored-by: Ayanava Karmakar <[email protected]>

* dont need to restart dev server

* remove the nose

* capital c

* add discord deployment note

* prettier

* Update www/src/pages/en/usage/first-steps.md

Co-authored-by: Ayanava Karmakar <[email protected]>

* Update www/src/pages/en/usage/first-steps.md

Co-authored-by: Ayanava Karmakar <[email protected]>

Co-authored-by: Shoubhit Dash <[email protected]>
Co-authored-by: Ayanava Karmakar <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanavaKarmakar AyanavaKarmakar AyanavaKarmakar requested changes

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

@nexxeln nexxeln Awaiting requested review from nexxeln

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c-ehrlich @juliusmarminge @AyanavaKarmakar @nexxeln