Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: next-auth doesn't install when using node 18 and 19 #642

Merged
merged 3 commits into from
Oct 23, 2022
Merged

fix: next-auth doesn't install when using node 18 and 19 #642

merged 3 commits into from
Oct 23, 2022

Conversation

c-ehrlich
Copy link
Member

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • If the user is on node 18 and chooses to install during cli, --ignore-engines true (yarn) or --engines-strict false (npm or pnpm) is used
  • If next-auth is selected, .npmrc and .yarnrc files with the same flags are created, regardless of what node version the user is currently on
  • FIXME's linking to the next-auth issue so that we can hopefully get rid of this again ASAP. I'm also subscribed to the issue.
  • Tested with current versions of npm, yarn classic, and pnpm

I don't love doing this and could also see the argument for just leaving next-auth not working on node 18 until they release a fix, but personally I'm leaning towards this (not great) solution for the time being.

I'd also appreciate a Windows user confirming that this works before we merge.

💯

@c-ehrlich c-ehrlich added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 23, 2022
@vercel
Copy link

vercel bot commented Oct 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
create-t3-app ⬜️ Ignored (Inspect) Oct 23, 2022 at 10:35AM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-nextauth-node18-t3-oss.vercel.app/

@github-actions
Copy link
Contributor

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

npx [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 23, 2022
@t3-oss t3-oss deleted a comment from changeset-bot bot Oct 23, 2022
@juliusmarminge
Copy link
Member

I don't love doing this and could also see the argument for just leaving next-auth not working on node 18 until they release a fix, but personally I'm leaning towards this (not great) solution for the time being.

Since Node 18 will be LTS soon, I think we should definitely support it. Just a shame you have to workarounds to get certain libraries to follow along :(

@c-ehrlich @juliusmarminge
also check for node 19
57c12f2 
Co-authored-by: Julius Marminge <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2022

🦋 Changeset detected

Latest commit: 57c12f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nexxeln
nexxeln approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@nexxeln nexxeln merged commit 9639419 into next Oct 23, 2022
@nexxeln nexxeln deleted the nextauth-node18 branch October 23, 2022 10:40
@nexxeln nexxeln changed the title fix: next-auth doesn't install when using node 18 fix: next-auth doesn't install when using node 18 and 19 Oct 23, 2022
@github-actions github-actions bot mentioned this pull request Oct 23, 2022
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@c-ehrlich @juliusmarminge
fix: next-auth doesn't install when using node 18 (t3-oss#642)
9403432 
* node 18 next-auth engines fix

* chore: add changeset

* also check for node 19

Co-authored-by: Julius Marminge <[email protected]>

Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge left review comments

@nexxeln nexxeln nexxeln approved these changes

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c-ehrlich @juliusmarminge @nexxeln